Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array types in SchemaWalker #956

Closed
nandorsoma opened this issue Oct 29, 2024 · 1 comment
Closed

Support array types in SchemaWalker #956

nandorsoma opened this issue Oct 29, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers graphql

Comments

@nandorsoma
Copy link
Contributor

When a field is defined in the GraphQL schema and its underlying type is an array, the compilation currently fails with a RuntimeException.

For example, consider the following query where a function returns a double[]:

results := SELECT prompt AS pr,
    vector_embedd(prompt, 'text-embedding-ada-002') AS em
    FROM data;

If the em field is not included in the GraphQL schema, compilation succeeds without issue. However, if em is added to the schema, compilation fails because the necessary mapping for arrays is not implemented.

type Results {
  pr: String
  em: [Int]
}

type Query {
  results(pr: String, limit: Int = 10, offset: Int = 0): [Results!]
}

For more context on the source of the issue, refer to the following line in the SchemaWalker.java file:
SchemaWalker.java - Line 114

@github-project-automation github-project-automation bot moved this to Backlog in DataSQRL Oct 29, 2024
@henneberger henneberger moved this from Backlog to Ready in DataSQRL Oct 29, 2024
@henneberger henneberger added enhancement New feature or request graphql good first issue Good for newcomers labels Oct 29, 2024
@henneberger
Copy link
Contributor

Fixed in #982

@github-project-automation github-project-automation bot moved this from Ready to Done in DataSQRL Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers graphql
Projects
Status: Done
Development

No branches or pull requests

2 participants