Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Neural Net #12

Open
wants to merge 5 commits into
base: datawave_ml
Choose a base branch
from
Open

Load Neural Net #12

wants to merge 5 commits into from

Conversation

jatkinson1000
Copy link
Member

@jatkinson1000 jatkinson1000 commented Jun 17, 2024 •
edited
Loading

Closes #11

This is built on top of #9 which is itself build upon #4 and #5.

Testing using the CAM_GW_Net case on Derecho.

  • Add filepath to neural net that can be read in from the namelist
  • Read in and scatter to processes
  • Generate a net on each process in the setup
  • Destroy at the end of the physics routine

@jatkinson1000 jatkinson1000 self-assigned this Jun 17, 2024
@jatkinson1000
Copy link
Member Author

This is now ready for review.

It loads the net during the init phase of the simulation, and adds a gw_final subroutine to destroy it at the end.
The net is then available to be called within the gw_drag module as a module variable.

surbhigoel77
surbhigoel77 reviewed Jul 31, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
surbhigoel77
surbhigoel77 reviewed Aug 4, 2024
View reviewed changes
bld/namelist_files/namelist_defaults_cam.xml Outdated Show resolved Hide resolved
bld/namelist_files/namelist_definition.xml Outdated Show resolved Hide resolved
bld/namelist_files/namelist_definition.xml Outdated Show resolved Hide resolved
yqsun91
yqsun91 approved these changes Aug 19, 2024
View reviewed changes
Copy link

@yqsun91 yqsun91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have gone through this and it looks good to me.

One question? are we making additional changes to save the tendency term? utgw & vtgw for example. I did not find it here. But I think it is needed.

@jatkinson1000
Copy link
Member Author

Thanks @yqsun91
Good question - Yes, we will save those variables, but that will be part of #14 - here I am specifically focussing on being able to load a net using FTorch and set up the surrounding infrastructure.

@jatkinson1000
Copy link
Member Author

Note that due to delays in reviewing this PR went stale as it has been incorporated into #14 which builds on top of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yqsun91 yqsun91 yqsun91 approved these changes

@surbhigoel77 surbhigoel77 Awaiting requested review from surbhigoel77

Assignees

@jatkinson1000 jatkinson1000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load neural net in from filepath
3 participants
@jatkinson1000 @surbhigoel77 @yqsun91