Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate alternative to flask #273

Open
DavAug opened this issue Dec 15, 2023 · 0 comments
Open

Investigate alternative to flask #273

DavAug opened this issue Dec 15, 2023 · 0 comments

Comments

@DavAug
Copy link
Owner

DavAug commented Dec 15, 2023

Below comments from JOSS review:

Certainly not required but ruff is an excellent alternative to Flake8, it covers all the rules Flake8 does, is considerably faster and has a pre-commit hook which can be added and integrated with GitHub Actions via pre-commit.ci. For more on this see Research Software Engineering Sheffield - pre-commit : Protecting your future self.

If you've ever time to work on this I can highly recommend pre-commit and pre-commit.ci the later of which integrates well with a GitHub action and catches instances where contributors might not have applied Flake8 locally before commits (I added some links to more information in a openjournals/joss-reviews#5925 (comment) that may be useful).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant