Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs show optionals as required #44

Closed
lalalune opened this issue May 7, 2024 · 4 comments
Closed

Docs show optionals as required #44

lalalune opened this issue May 7, 2024 · 4 comments
Assignees
Milestone

Comments

@lalalune
Copy link
Contributor

lalalune commented May 7, 2024

Screenshot 2024-05-06 at 11 26 21 PM
@lalalune lalalune added this to the 1.0 milestone May 9, 2024
@lalalune lalalune assigned AqeelAqeel and unassigned eric-prog May 9, 2024
@lalalune lalalune modified the milestones: 1.0, 2.0 May 12, 2024
@AqeelAqeel AqeelAqeel self-assigned this May 12, 2024
@AqeelAqeel
Copy link
Contributor

docs/batch_rendering.md
Screenshot 2024-05-11 at 10 47 05 PM

arguments / docstring is where we're supposed to read this in for MKDocs. might be reading it in incorectly.

Will keep looking / reviewing MK Docs more

@lalalune
Copy link
Contributor Author

mkdocstrings/griffe#165

Seems like we need to structure it like this

class Example(NamedTuple):
"""A simple example of the autorefs bug

Parameters
----------
required : int
    A required value
optional : float, optional
    An optional value, default is -3.6
"""

@pawamoy
Copy link

pawamoy commented May 19, 2024

In the screenshot above, it looks like you're using the Google-style for docstrings. Just remove the dashes in front of parameter names and it should work as expected.

Otherwise, yes, you can also switch to the Numpydoc-style if this is what you prefer :)

@lalalune
Copy link
Contributor Author

In the screenshot above, it looks like you're using the Google-style for docstrings. Just remove the dashes in front of parameter names and it should work as expected.

Otherwise, yes, you can also switch to the Numpydoc-style if this is what you prefer :)

Thank you, very useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants