improve GetInStation filter #33405
Open
improve GetInStation filter #33405
+38
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
beck-thompson
added
T: Bugfix
TheShuEd
approved these changes
Nov 18, 2024
metalgearsloth
added
S: Awaiting Changes
github-actions
bot
added
S: Needs Review
|
Wish this would be reviewed or merged, the issues it's causing downstream are very annoying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
actually checks if you're on the station now, and if not, it checks if you're in the specified range
fixes DeltaV-Station/Delta-v#2228
Why / Balance
bug fix
Technical details
removed the initial bounds collection pass and now build bounds only when needed
added a transform parent traversal to check if players are directly on station grids
Requirements
Breaking changes
Changelog
no fun