Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support D-Water Quality input in ExtOldModel #551

Open
SCLaan opened this issue Jun 28, 2023 · 3 comments
Open

Support D-Water Quality input in ExtOldModel #551

SCLaan opened this issue Jun 28, 2023 · 3 comments
Assignees
Labels
priority: high type: compatibility Changes needed to be compatible with the computational core

Comments

@SCLaan
Copy link

SCLaan commented Jun 28, 2023

Is your feature request related to a problem? Please describe.
At present when loading the old format ext file of a coupled D-Flow FM and D-Water Quality model multiple validation errors occur, because the water quality input is not yet supported.

Describe the solution you'd like
I would like to see support for water quality input in ExtOldModel. These errors occur for the following input under QUANTITY:

  • waqfunctionXXX (with a user specified function, e.g. waqfunctionRadSurf, waqfunctionVWind)
  • waqmassbalanceareaXXX (with a user specified domain name)
  • waqparameterXXX (with a user specified parameter name)
  • tracerbndXXX (in combination with FILETYPE=9)
  • initialtracerXXX (in combination with FILETYPE=10)
  • initialwaqbotXXX (in combination with FILETYPE=10)

Describe alternatives you've considered
none

Additional context
MWE:

from pathlib import Path
import hydrolib.core.dflowfm as hcdfm

ext_file = Path(r'p:\11208983-epd-support-tools\training\HK-DFM_Day3_WaterQuality\Demo_Model_Input\HK-FM_bnd.ext')
ext_data = hcdfm.ExtOldModel(ext_file)
@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jan 15, 2024

updated path:

import hydrolib.core.dflowfm as hcdfm
ext_file = r'p:\11208983-epd-support-tools\training\HK-DFM_June2023\HK-DFM_Day3_WaterQuality\Demo_Model_Input\HK-FM_bnd.ext'
ext_data = hcdfm.ExtOldModel(ext_file, recurse=False)

@priscavdsluis priscavdsluis added type: compatibility Changes needed to be compatible with the computational core priority: high labels Apr 9, 2024
@tim-vd-aardweg
Copy link
Contributor

Let's discuss the details @veenstrajelmer & @rhutten

@tim-vd-aardweg
Copy link
Contributor

Assigned the issue to @rhutten. She will determine if/when we will pick up this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high type: compatibility Changes needed to be compatible with the computational core
Projects
Status: To do
Development

No branches or pull requests

5 participants