Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo the suppressing of xarray chunking warning #888

Closed
5 tasks done
veenstrajelmer opened this issue Jul 9, 2024 · 0 comments · Fixed by #918
Closed
5 tasks done

Undo the suppressing of xarray chunking warning #888

veenstrajelmer opened this issue Jul 9, 2024 · 0 comments · Fixed by #918

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jul 9, 2024

The xarray chunking warning was suppressed in #679. However, significant performance improvements can be achieved if properly solving this: Deltares/xugrid#252

Todo:

  • wait for new xugrid release including Merge partition chunks xugrid#253
  • update minimal xugrid requirement (also relevant for from_meshkernel method: use all attributes xugrid#148)
  • remove suppressing of the chunking warning again, although this was printed for each partition, not upon merging. It seems to have vanished though. Was it then indeed a mistake in xarray?
  • check warnings in py3.9-mindeps and py3.12 pytest testcases
  • solve remaintin warning in test_xarray_decode_default_fillvals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant