Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test_prevent_dtype_int #942

Closed
veenstrajelmer opened this issue Aug 9, 2024 · 0 comments · Fixed by #943
Closed

fix test_prevent_dtype_int #942

veenstrajelmer opened this issue Aug 9, 2024 · 0 comments · Fixed by #943

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Aug 9, 2024

FAILED tests/test_xarray_helpers.py::test_prevent_dtype_int because the merged file sizes of files retrieved with the new CDS-beta (#739) are different. This happens because ERA5 data is now zipped float instead of scaled int. So in fact, the prevent_dtype_int is not needed anymore for this new data.

However, for compatibility with old (already downloaded) ERA5 netcdf files, do check whether there are no scale_factor (etc) attrs present upon merging, otherwise we get corrupt files like in #239. If these attrs are present, drop them and convert dtype to float

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant