You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code below raises "ValueError: metadata for two datasets is not equal, cannot be merged:" because of varying timestep_min. This should be ignored when merging timeseries.
This also includes setting the metadata from the first block as the metadata of the merged timeseries, which will then not contain a timestep_min. Also the tstart/tstop are derived assuming the blocks are ordered in time which is not always the case.
Todo:
add testcase that fails with current setup
drop tstart/tstop attrs from timeseries dataframes, only keep for component dataframes
drop tzone attrs from timeseries dataframes, only keep for component dataframes
drop timestep_min attrs from timeseries dataframes, can probably be dropped throughout the code
remove timestep_min from metadata before comparing them (but keep in mind that it is added as metadata to the merged dataset also) >> not added to metadata anymore
The text was updated successfully, but these errors were encountered:
veenstrajelmer
changed the title
metadata comparison slightly too strict for hatyan.read_dia()
metadata comparison too strict for hatyan.read_dia()Jun 4, 2024
The code below raises
"ValueError: metadata for two datasets is not equal, cannot be merged:"
because of varyingtimestep_min
. This should be ignored when merging timeseries.The code for metadata comparison is this part:
hatyan/hatyan/timeseries.py
Lines 1584 to 1590 in 8a004bc
This also includes setting the metadata from the first block as the metadata of the merged timeseries, which will then not contain a timestep_min. Also the tstart/tstop are derived assuming the blocks are ordered in time which is not always the case.
Todo:
The text was updated successfully, but these errors were encountered: