Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up hatyan.calc_HWLW12345to12() #350

Closed
veenstrajelmer opened this issue Sep 6, 2024 · 0 comments · Fixed by #351
Closed

clean up hatyan.calc_HWLW12345to12() #350

veenstrajelmer opened this issue Sep 6, 2024 · 0 comments · Fixed by #351

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Sep 6, 2024

Todo:

  • with the current method there is no first LW computed even if the timeseries would start with 3/4/5, since that function starts with the first HW. This could be avoided by adding a dummy HW at the start of the timeseries, although in case of only 5 that might result in a wrong LW. >> leave this be
  • there is an exception included to continue if the last HW is also the last value of the timeseries. This is not necessary since it is already catched by len(tide_afterHW)==0 so this can be removed >> this is an exception to ignore missing LW's, which is useful to keep
  • code cleanups
  • expand test coverage with specific testcases
@veenstrajelmer veenstrajelmer linked a pull request Sep 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant