Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make @fluent/bundle a peer dependency #43

Closed
erickwilder opened this issue Feb 16, 2020 · 1 comment · Fixed by #44
Closed

Make @fluent/bundle a peer dependency #43

erickwilder opened this issue Feb 16, 2020 · 1 comment · Fixed by #44
Labels
released

Comments

@erickwilder
Copy link
Contributor

I'm wondering if users of this library should be given the freedom to install any @fluent/bundle version that is compatible with this project. The README also states that installation of @fluent/bundle is part of the configuration steps, so no changes in the workflow are expected.

By comparison, this is exactly what @fluent/react does. Other dependencies could remain as production dependencies (e.g. @fluent/dedent, and @fluent/sequence)
Demivan added a commit that referenced this issue Feb 16, 2020
@Demivan
fix(package): make @fluent/bundle a peer dependency
3eb5f83 
fix #43
@Demivan Demivan mentioned this issue Feb 16, 2020
Merged
Demivan added a commit that referenced this issue Feb 16, 2020
@Demivan
fix(package): make @fluent/bundle a peer dependency and @fluent/deden…
14c487c 
…t a dev dependency

fix #43
@Demivan
Copy link
Member

Demivan commented Feb 16, 2020

🎉 This issue has been resolved in version 2.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make @fluent/bundle a peer dependency fluent-vue/fluent-vue
2 participants
@erickwilder @Demivan