Skip to content

Commit

Permalink
Port "Remove jQuery from the repo release form"
Browse files Browse the repository at this point in the history
Port of go-gitea/gitea#29225. Reworked to not
use global click event listener.

---

- Switched to plain JavaScript
- Tested the repo release form functionality and it works as before
  • Loading branch information
yardenshoham authored and Gusted committed Feb 19, 2024
1 parent cfd6420 commit 6b1f660
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions web_src/js/features/repo-release.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
import $ from 'jquery';
import {hideElem, showElem} from '../utils/dom.js';
import {initComboMarkdownEditor} from './comp/ComboMarkdownEditor.js';

export function initRepoRelease() {
$(document).on('click', '.remove-rel-attach', function() {
const uuid = $(this).data('uuid');
const id = $(this).data('id');
$(`input[name='attachment-del-${uuid}']`).attr('value', true);
hideElem($(`#attachment-${id}`));
[...document.querySelectorAll('.remove-rel-attach')].forEach((el) => {
el.addEventListener('click', (e) => {
const uuid = e.target.getAttribute('data-uuid');
const id = e.target.getAttribute('data-id');
document.querySelector(`input[name='attachment-del-${uuid}']`).value = 'true';
hideElem(`#attachment-${id}`);
});
});
}

export function initRepoReleaseNew() {
const $repoReleaseNew = $('.repository.new.release');
if (!$repoReleaseNew.length) return;
if (!document.querySelector('.repository.new.release')) return;

initTagNameEditor();
initRepoReleaseEditor();
Expand Down Expand Up @@ -45,9 +45,9 @@ function initTagNameEditor() {
}

function initRepoReleaseEditor() {
const $editor = $('.repository.new.release .combo-markdown-editor');
if ($editor.length === 0) {
const editor = document.querySelector('.repository.new.release .combo-markdown-editor');
if (!editor) {
return;
}
const _promise = initComboMarkdownEditor($editor);
initComboMarkdownEditor(editor);
}

0 comments on commit 6b1f660

Please sign in to comment.