Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the onnx-mlir version #10

Closed
uditagarwal97 opened this issue May 12, 2022 · 2 comments
Closed

Update the onnx-mlir version #10

uditagarwal97 opened this issue May 12, 2022 · 2 comments

Comments

@uditagarwal97
Copy link
Collaborator

It looks like ONNX-MLIR is now a lot more mature and supports 116 ML models out of 128 Models from the ONNX Zoo, including large models like Bert and GPT. Ref: onnx/onnx-mlir#128.

We should seriously consider upgrading the onnx-mlir version being used with LLTFI.
@uditagarwal97 uditagarwal97 mentioned this issue May 12, 2022
Open
@uditagarwal97
Copy link
Collaborator Author

@abrahamchan I have updated the onnx-mlir version to commit id 9c62e1a4. However, I had to make certain changes in instrumentation passes of the onnx-mlir code to get LLTFI working with it. We have to decide whether 1) I should keep my changes as a patch and apply the patch to onnx-mlir? Or 2) we fork the onnx-mlir repository to DependableSystemsLab GitHub org and I make changes to the forked version of onnx-mlir.

@uditagarwal97
Copy link
Collaborator Author

We added a patch of our changes.

@hjiang13 hjiang13 mentioned this issue Sep 19, 2022
Closed
@karthikp-ubc karthikp-ubc mentioned this issue Dec 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@uditagarwal97