Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Investigate Adding a Variant Based Implementation #33

Open
DeveloperPaul123 opened this issue Sep 13, 2024 · 1 comment
Open
Labels
enhancement:dev enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@DeveloperPaul123
Copy link
Owner

After a discussion on my discord with a user, it came up that there may be some easy performance gains by using std::variant instead of std::any with std::any_cast. I'd like to investigate looking into using this as an alternative implementation of the event bus and then allow users to opt in (or out) of a particular implementation using a policy or something similar.

There should also be a benchmark to compare the performance between the two implementations (mostly to see how long event dispatch takes).

@DeveloperPaul123 DeveloperPaul123 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers enhancement:dev labels Sep 13, 2024
@DeveloperPaul123
Copy link
Owner Author

@games-on-whales has implemented an initial version of the variant version here: https://github.com/games-on-whales/eventbus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:dev enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant