binance 400 bad request during backfill and trading

[dakreepy1]

Please go to Stack Overflow for help and support:

https://stackoverflow.com/questions/tagged/zenbot

If you open a GitHub issue, here is our policy:

1. It must be a bug or a feature request.
2. The form below must be filled out.

Here's why we have that policy: Zenbot developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies hundreds of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.

---

System information

• Have I written custom code (as opposed to using zenbot vanilla): no
• OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
• Zenbot version: latest unstable
• NodeJS version: 8.9.4
• Python version: 2.7.12
• Exact command to reproduce: ./zenbot.sh backfill binance.ETH-BTC --days 7

Describe the problem

unable to run agains binance exchange. From what I can tell the request for trade data is passing a limit for the amount to return that is blank as shown in the error output:
GET https://api.binance.com/api/v1/aggTrades?symbol=ETHBTC&startTime=1516805725241&endTime=1516809325241&limit=

if i try this url in a browser without the limit= i get data returned. If i try with a value, i get the amount of records i entered for the limit value.

I also am running the latest version of the npm packages (using npm update in the zenbot directory) I tried reverting back to the package.json ones to no avail.

Source code / logs

An error occurred { Error: binance GET https://api.binance.com/api/v1/aggTrades?symbol=ETHBTC&startTime=1516805725241&endTime=1516809325241&limit= 400 Bad Request {"code":-1105,"msg":"Parameter 'limit' was was empty."} (possible reasons: invalid API keys, bad or old nonce, exchange is down or offline, on maintenance, DDoS protection, rate-limiting)
at binance.defaultErrorHandler (/home/ryan/zenbot/node_modules/ccxt/js/base/Exchange.js:439:15)
at response.text.then.responseBody (/home/ryan/zenbot/node_modules/ccxt/js/base/Exchange.js:457:18)
at
at process._tickCallback (internal/process/next_tick.js:188:7) constructor: [Function: ExchangeNotAvailable] }