From af50930149af48e9213db83e9a1b2ff7f2af7d15 Mon Sep 17 00:00:00 2001 From: Callum Forrester Date: Mon, 2 Dec 2024 12:22:06 +0000 Subject: [PATCH] Remove extra span attrs and fix typo --- src/blueapi/service/runner.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/blueapi/service/runner.py b/src/blueapi/service/runner.py index 4a8645c39..d8d957055 100644 --- a/src/blueapi/service/runner.py +++ b/src/blueapi/service/runner.py @@ -8,7 +8,6 @@ from typing import Any, ParamSpec, TypeVar from observability_utils.tracing import ( - add_span_attributes, get_context_propagator, get_tracer, start_as_current_span, @@ -70,7 +69,6 @@ def reload(self): @start_as_current_span(TRACER) def start(self): - add_span_attributes({"_use_subprocess": True, "_config": str(self._config)}) try: self._subprocess = self._subprocess_factory() self.run(setup, self._config) @@ -108,14 +106,12 @@ def run( **kwargs: P.kwargs, ) -> T: """Call the supplied function, passing the current Span ID, if one - exists,from the observability context inro the import_and_run_function + exists,from the observability context into the import_and_run_function caller function. When this is deserialized in and run by the subprocess, this will allow its functions to use the corresponding span as their parent span.""" - add_span_attributes({"use_subprocess": True}) - if self._subprocess is None: raise InvalidRunnerStateError("Subprocess runner has not been started") if not (hasattr(function, "__name__") and hasattr(function, "__module__")):