Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dodal.common.MsgGenerator and dls_bluesky_core.core.MsgGenerator not equal #643

Closed
DiamondJoseph opened this issue Sep 17, 2024 · 4 comments · Fixed by #645
Closed

dodal.common.MsgGenerator and dls_bluesky_core.core.MsgGenerator not equal #643

DiamondJoseph opened this issue Sep 17, 2024 · 4 comments · Fixed by #645
Assignees
@DiamondJoseph
Labels
bug Something isn't working

Comments

@DiamondJoseph
Copy link
Contributor

Previously we had checked that plans were annotated with is dls_bluesky_core.core.MsgGenerator. This began causing issue, and we had to check == dls_bluesky.core.core.MsgGenerator. This now appears to also not be compatible in a built container.

It is time for a clean break and removal of dls_bluesky_core. But also a cautionary tale if we to move MsgGenerator into bluesky.

Originally posted by @DiamondJoseph in #533 (comment)
@DiamondJoseph DiamondJoseph self-assigned this Sep 17, 2024
@DiamondJoseph DiamondJoseph added the bug Something isn't working label Sep 17, 2024
@DiamondJoseph DiamondJoseph mentioned this issue Sep 17, 2024
Merged
@callumforrester
Copy link
Contributor

Shall we now get it all to point at the one in bluesky main: https://github.com/bluesky/bluesky/blob/7c2a44f09a747f59a17abc6cfdfe934c61c266fb/src/bluesky/utils/__init__.py#L98

@DiamondJoseph
Copy link
Contributor Author

Has that really been there 6 months...

@DiamondJoseph
Copy link
Contributor Author

There hasn't been a release since it went in. I'm chasing up now.

@DiamondJoseph DiamondJoseph mentioned this issue Oct 10, 2024
Merged
4 tasks
@DiamondJoseph
Copy link
Contributor Author

Closed by #832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiamondJoseph DiamondJoseph

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

No dls bluesky DiamondLightSource/blueapi
2 participants
@callumforrester @DiamondJoseph