-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare ZocaloResults
to use multiple results sources
#559
Prepare ZocaloResults
to use multiple results sources
#559
Comments
Need to discuss with Nick on multiple messages vs single messages with both results |
@ndevenish says it will be multiple messages. For implementing this lets assume the format is:
It'll be close to that I suspect. Nick, feel free to correct us if you have a better idea of the format. |
You are listening to messages directly, right? Are you getting the messages back from the It might be in the message parameters, along with dcid/dcgid, is that okay? |
As discussed with @DominicOram:
|
As part of this issue: if we are using gpu results, we would like to compare data from GPU and CPU results and include it in a debug log, and warn if the results differ by some tolerance (TBC) This should be done asynchronously so we aren't still being blocked by slow CPU results |
Updated acceptance criteria:
|
Changes are currently on the beamline to use the CPU results no matter what. Update this accordingly |
I03 will soon have both GPU-based and traditional xray-centring results available.
ZocaloResults
should fetch both of these from the queue and pick which one to use based on input from hyperion.The text was updated successfully, but these errors were encountered: