Remove token feature #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove token feature and allow the browser to do basic auth
TBThomas56
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
Remove token feature and allow the browser to do basic auth.
Without the token, the browser will prompt for credentials when an API call is made and embed them automatically: https://stackoverflow.com/questions/23004942/how-can-i-get-browser-authentication-popup
This will only last as long as the browser is open, the user will have to be prompted again after a restart. It's not perfect but it is sufficient for MVP.
Longer-term we will need to use cookies and graylog's session endpoint: https://go2docs.graylog.org/5-0/setting_up_graylog/rest_api.html