Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panda grid scans don't correctly check for gridscan_valid #502

Closed
olliesilvester opened this issue Sep 17, 2024 · 2 comments
Closed

Panda grid scans don't correctly check for gridscan_valid #502

olliesilvester opened this issue Sep 17, 2024 · 2 comments

Comments

@olliesilvester
Copy link
Contributor

olliesilvester commented Sep 17, 2024 •
edited
Loading

PandA grid scans tried to kickoff a gridscan while the BL03I-MO-SGON-01:PGS:SCAN_INVALID was set to invalid (0). IOC logs show that panda grid scan parameters had been updated, so looking at the code, it is unclear why this PV wasn't being checked properly in wait_for_gridscan_valid. See graylog error: https://graylog.diamond.ac.uk/messages/graylog-daq-mx-hyperion_21/3c7fd880-702f-11ef-bc16-26706383e36b

One possible cause:
The invalid PV takes up to 0.1s to update after one of the grid scan parameters change (I think). Hyperion may be doing wait_for_gridscan_valid before the PV has properly updated. Within the time resolution of the IOC logs, this looks possible (but resolution too small to say for sure).
If that is the issue, not sure why we wouldn't have seen it for zebra FGS.

Acceptance Criteria

  • Issue is fixed, potentially by just adding a short sleep in wait_for_gridscan_valid
@olliesilvester olliesilvester mentioned this issue Sep 17, 2024
Closed
@olliesilvester
Copy link
Contributor Author

Issue is within EPICS, see https://jira.diamond.ac.uk/browse/I03-993

@olliesilvester olliesilvester mentioned this issue Oct 25, 2024
Closed
@olliesilvester
Copy link
Contributor Author

This is now fixed and released on I03, see above Jira ticket, and see the exact commit herre: https://gitlab.diamond.ac.uk/controls/support/smargon/-/commit/c5d40bb4e829302198e2daa813a9b179b4e140d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add sleep to gridscan validity check DiamondLightSource/mx-bluesky
1 participant
@olliesilvester