-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: supporting only node above 12 #84
Conversation
package.json
Outdated
@@ -30,23 +28,24 @@ | |||
"babel-plugin-transform-object-rest-spread": "^6.26.0", | |||
"babel-preset-env": "^1.7.0", | |||
"babel-register": "^6.26.0", | |||
"eslint": "^4.14.0", | |||
"eslint": "^4.19.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and I would 100% agree with you. Let me dot it
.github/workflows/tests.yml
Outdated
@@ -13,7 +13,7 @@ jobs: | |||
|
|||
strategy: | |||
matrix: | |||
node-version: [8.x, 10.x, 12.x] | |||
node-version: [10.x, 12.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node-version: [10.x, 12.x] | |
node-version: [10.x, 12.x, 14.x, 16.x] |
package.json
Outdated
"semantic-release": "^17.2.3" | ||
}, | ||
"peerDependencies": { | ||
"eslint-plugin-react": "^7.16.0" | ||
"eslint-plugin-react": "^7.16.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might as well hoist this up to the latest version of eslint-plugin-react also, since you're doing a breaking change anyways
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't have days off do you 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
every hour's an hour off from lots of things :-p there's just more than 24 hours worth of things to do in a day
@ljharb I think this should do it. lmk if you see anything off. Thank you 🙏 |
@@ -13,7 +13,7 @@ jobs: | |||
|
|||
strategy: | |||
matrix: | |||
node-version: [8.x, 10.x, 12.x] | |||
node-version: [12.x, 14.x, 16.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node-version: [12.x, 14.x, 16.x] | |
node-version: [12.x, 14.x, 16.x, 17.x] |
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
It is time to move on... Node8 is not supported starting eslint@7
closes #83