Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warehouse value #290

Closed
FrutyX opened this issue Nov 4, 2021 · 9 comments
Closed

Warehouse value #290

FrutyX opened this issue Nov 4, 2021 · 9 comments

Comments

@FrutyX
Copy link
Collaborator

FrutyX commented Nov 4, 2021

Re-purposed this issue (was something bit different before, don't ask, I am just an idiot).

This is an enhancement (I believe), would it be possible to enable this feature for warehouse too? I don't see any disadvantages, so why not. Personally I was looking for it.

gca

Shouldn't be too hard for you to do, just some little edits in merchants.js.

@FrutyX FrutyX changed the title Merchants + warehouse gold values Ignore. Nov 4, 2021
@FrutyX FrutyX closed this as completed Nov 4, 2021
@FrutyX FrutyX changed the title Ignore. Ignore. (Invalid) Nov 4, 2021
@FrutyX FrutyX changed the title Ignore. (Invalid) Warehouse value Nov 5, 2021
@FrutyX
Copy link
Collaborator Author

FrutyX commented Nov 5, 2021

Re-purposed.

@FrutyX FrutyX reopened this Nov 5, 2021
@FrutyX
Copy link
Collaborator Author

FrutyX commented Nov 5, 2021

It's weird that if(!document.getElementById("shop")) return; and warehouse has "shop" too, unless, you disabled it in warehouse on purpose.

Or we talking about a bug, I don't know.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Nov 6, 2021

Hmmm, I've been giving ideas and "instructions", but it is only fair to say why.

Well, recently I've started to save the most valuable scrolls into my warehouse, and I would like to know, how much gold I have there saved, I don't know if anyone else needs this, but then we go again, why not if it's already scripted.

@GreatApo
Copy link
Member

GreatApo commented Nov 7, 2021

We are not presenting the value sum in guild store because that may push guild members (especially low level players) to just empty the storage and sell the content.
I can see that it could be helpful for hiding gold (maybe for guild upgrades too), so it could be codes but disabled by default.

In terms of the code, merchants and guild.storage scripts are running in different pages each. There is a way to call functions from different scripts.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Nov 7, 2021

to just empty the storage and sell the content.

I am not saying that it's not true, but fortunately Gladiatus has a rank system with their own permissions, and you can set that for each shelf. A new player shouldn't have a rank with full permissions to the warehouse, if yes, then it's not GCAs fault, it's on the guild master and the administrators.

I was actually the warehouse master in my guild, and each rank had their permission to each specific shelf.
It's more work, but you could, if you wanted, to add this option to settings and leave it at least disabled by default.

@GreatApo
Copy link
Member

GreatApo commented Nov 7, 2021

to just empty the storage and sell the content.

I am not saying that it's not true, but fortunately Gladiatus has a rank system with their own permissions, and you can set that for each shelf. A new player shouldn't have a rank with full permissions to the warehouse, if yes, then it's not GCAs fault, it's on the guild master and the administrators.

I was actually the warehouse master in my guild, and each rank had their permission to each specific shelf. It's more work, but you could, if you wanted, to add this option to settings and leave it at least disabled by default.

Yeah I agree. I just explained why it is not already there :)

@GreatApo
Copy link
Member

GreatApo commented Nov 7, 2021

Commit 4c32075

@GreatApo GreatApo closed this as completed Nov 7, 2021
@GreatApo GreatApo reopened this Nov 7, 2021
@FrutyX
Copy link
Collaborator Author

FrutyX commented Nov 7, 2021

And once again you fulfill my request, and once again, I thank you for that.

This will prove useful.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Dec 8, 2021

On the list with #294.

Added, looking good, closing, re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants