Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting of children main size in flex length resolving to follow the spec #123

Closed
TimJentzsch opened this issue Jun 9, 2022 · 1 comment
Closed

Fix setting of children main size in flex length resolving to follow the spec #123

TimJentzsch opened this issue Jun 9, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@TimJentzsch
Copy link
Collaborator

What problem does this solve or what need does it fill?

Setting the main size of the children when resolving the flexible lengths does not seem to follow the specification:
https://github.com/DioxusLabs/sprawl/blob/11701ee97d68b22a231cac081aab4308af136706/src/flexbox.rs#L519-L522

What solution would you like?

The implementation should be adjusted to follow the specification and refactored if necessary.

What alternative(s) have you considered?

If it works we could also leave it as-is.

Additional context

Originally discussed in #39.
@TimJentzsch TimJentzsch added the bug Something isn't working label Jun 9, 2022
@alice-i-cecile alice-i-cecile added the good first issue Good for newcomers label Jun 12, 2022
@nicoburns nicoburns removed the good first issue Good for newcomers label Dec 30, 2022
@nicoburns
Copy link
Collaborator

This was fixed in #294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicoburns @alice-i-cecile @TimJentzsch