Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send changed properties to the lamps #121

Open
Dirnei opened this issue Feb 8, 2022 · 1 comment
Open

Only send changed properties to the lamps #121

Dirnei opened this issue Feb 8, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Dirnei
Copy link
Owner

Dirnei commented Feb 8, 2022

Xploder mentioned it on discord that state, brightes and so on are always in the payload. It would be better to send only the changed properties to the lamp.

This implies that we should also remove the value from the generic-lamp node and only use the override-nodes.

@Andreas-Huber what do you think of my idea?

@Dirnei Dirnei added the enhancement New feature or request label Feb 8, 2022
@Dirnei Dirnei added this to the Release 0.20.0 milestone Feb 8, 2022
@Dirnei Dirnei self-assigned this Feb 8, 2022
@Andreas-Huber
Copy link
Collaborator

I think that is a brilliant Idea.
Removing the state from the generic lamp node is definitely a breaking change. But I would make things certainly more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants