-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(network): add simple db caching layer to NetworkManager()
#61
Conversation
dev-737
commented
Apr 27, 2024
- Added a simple caching layer for so database doesn't get queried too much
- Reduce complexity of some methods. Refactor stuff basically
Here's the code health analysis summary for commits Analysis Summary
|
Graphite Automations"Auto-assign PRs to author" took an action on this PR • (04/27/24)1 assignee was added to this PR based on 's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trust me all I can say is LGTM, except changing eslint to warn instead of error is quite something.
Lmao, appreciate your review! On a side-note, I'm not sure how to get husky working again, lint check during commit isn't triggering anymore. Any ideas? |
You don’t have |
NetworkManager()
NetworkManager()
Was actually missing a postinstall script for husky 😝 |