Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network): add simple db caching layer to NetworkManager() #61

Merged
merged 8 commits into from
Apr 30, 2024

Conversation

dev-737
Copy link
Member

@dev-737 dev-737 commented Apr 27, 2024

  • Added a simple caching layer for so database doesn't get queried too much
  • Reduce complexity of some methods. Refactor stuff basically

@dev-737 dev-737 requested a review from Chanakan5591 April 27, 2024 14:52
@dev-737 dev-737 added feature New feature or request refactor something that needs a code refactor labels Apr 27, 2024
Copy link

deepsource-io bot commented Apr 27, 2024

Here's the code health analysis summary for commits b47dd8d..5a97f5d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 14 occurences introduced
🎯 3 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

graphite-app bot commented Apr 27, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (04/27/24)

1 assignee was added to this PR based on 's automation.

Copy link
Contributor

@Chanakan5591 Chanakan5591 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trust me all I can say is LGTM, except changing eslint to warn instead of error is quite something.

@dev-737
Copy link
Member Author

dev-737 commented Apr 28, 2024

trust me all I can say is LGTM, except changing eslint to warn instead of error is quite something.

Lmao, appreciate your review! On a side-note, I'm not sure how to get husky working again, lint check during commit isn't triggering anymore. Any ideas?

@Chanakan5591
Copy link
Contributor

You don’t have lint-staged script anymore, but I can see lint script. Maybe that’s what you want to change to within the pre-commit hook.

@dev-737 dev-737 changed the title feat(network): add simple cb caching layer to NetworkManager() feat(network): add simple db caching layer to NetworkManager() Apr 29, 2024
@dev-737
Copy link
Member Author

dev-737 commented Apr 29, 2024

Was actually missing a postinstall script for husky 😝

@dev-737 dev-737 merged commit 769fa5d into main Apr 30, 2024
1 of 2 checks passed
@dev-737 dev-737 deleted the network_refactor branch April 30, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactor something that needs a code refactor
Projects
No open projects
Status: 🚀 Shipped
Development

Successfully merging this pull request may close these issues.

2 participants