This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Rework abstract mapper to allow configure static type map in di.xml #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afirlejczyk
suggested changes
Oct 8, 2019
src/module-vsbridge-indexer-catalog/Index/Mapping/AbstractMapping.php
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently staticFieldMapping is in private field which is not possible to extend or reach by any manner. Also no public can be plugined to add or change static mapping. Only overriding is viable but overriding is BAD as we all know and all classes attributes are private and also some methods are.
I moved staticFieldMapping from a private attribute to a constructor so anyone can configure list simply by adding or changing it from di.xml. That will make that class a little bit more open for changes (SOLID) without changing the class itself.
I encountered a real life scenario where I had to be sure that an attribute will be of given type and I did not find any good solution.