This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
✨ (Added events to reindex command.) #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This command should be refactored, logic should be moved - I plan to this sometime in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
unfortunately, the whole reindexing logic lives inside of private or protected methods which makes it impossible to customize or extend it. To not be forced to overwrite the whole thing, I added two events that are triggered before and after the full reindex process.
This would also solve our issue in Issue 266.
I made the additional dependency a proxy, to make sure there are no issues regarding the performance or future maintainability.