-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eigen includes #7
Conversation
Hmm travis fails now with |
If you include the repo as a submodule, there's no `nlohmann/` directory. The file is in the directory `src/` (https://github.com/nlohmann/json/blob/develop/src/json.hpp), and should be included via `#include "json.hpp"`, see the nlohmann/json readme: https://github.com/nlohmann/json#integration
Regarding the json include, I've opened nlohmann/json#942 upstream, I'm curious about their comment. |
Nice, thanks a lot. 👍 |
OK, now we are back to the include error. It seems like doing |
It looks like you're correct. |
Probably, yeah. At least the documentation states:
|
Ah yes, good find! Slightly annoying though I guess that the headers don't just get copied to |
What do you think about adding |
Sorry for the late reply! I think for travis, it's an acceptable fix. But I wouldn't advise to people in the readme to symlink stuff in Regarding nlohmann/json, it actually seems like there were some people discussing this issue in parallel and they've just merged a fix with proper include directories to the develop branch, and if I read correctly it'll be released tomorrow I think. |
Well, the symlink thing is what the Eigen documentation suggests. ;-) The json fix seems to be merged into master, right? So how do you think we should continue with this PR here? |
Yep they released 3.1.0 today :-) Agree I wouldn't go for the Eigen submodule. What I meant was actually not that, but just using |
Ok - so, the CMakeLists.txt of fdeep is quite rudimentary. What should sort-of ideally be done is to add a CMake target for the library, and then use But for the sake of this PR, let's fix it with the symlink and update nlohmann/json. I'll push shortly. |
This should allow the Eigen headers to be found with e.g. `#include "Eigen/Core"`.
This reverts commit 905f1e5.
I think we're ready to merge here. |
Hi!
The correct include for Eigen is
Eigen/Core
, without theeigen3
:-)Thank you for making this library available open source!