Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(functions): allow ref to correctly handle CommaDelimitedList #354

Merged
merged 3 commits into from
Oct 31, 2024
Merged

fix(functions): allow ref to correctly handle CommaDelimitedList #354

merged 3 commits into from
Oct 31, 2024

Conversation

dhutchison
Copy link
Collaborator

@dhutchison dhutchison commented Sep 23, 2024 •
edited
Loading

Leaving this as a draft just now as I've just twigged there are other List<foo> parameter types which will have the same issue. Will pick up that tomorrow.

@dhutchison dhutchison linked an issue Sep 23, 2024 that may be closed by this pull request
Unable to use CommaDelimitedList Parameters as inputs to intrinsic functions #353
Closed
@dhutchison dhutchison added bug Something isn't working patch A bug, doc or CICD change. labels Sep 23, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.87%. Comparing base (4fb3eec) to head (7f2f76b).
Report is 31 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #354      +/-   ##
===========================================
+ Coverage    94.85%   94.87%   +0.02%     
===========================================
  Files           12       12              
  Lines          835      839       +4     
  Branches       165      166       +1     
===========================================
+ Hits           792      796       +4     
  Misses          24       24              
  Partials        19       19
Flag Coverage Δ
unit 94.87% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhutchison dhutchison marked this pull request as draft September 23, 2024 23:29
@dhutchison dhutchison marked this pull request as ready for review September 24, 2024 22:07
@dhutchison
Copy link
Collaborator Author

@shadycuz looks like the license compliance check has got stuck again - do you know why?

Could you review / merge / release this? Thanks.

@jamesmcminn96
Copy link

Hey @shadycuz & @dhutchison, thanks heaps for the work on this so far. Wondering if it'd be possible for a new release with this fix to be cut soon?

@shadycuz
Copy link
Member

Hey @shadycuz & @dhutchison, thanks heaps for the work on this so far. Wondering if it'd be possible for a new release with this fix to be cut soon?

Yes, this is my fault. I will take care of shortly.

@shadycuz shadycuz merged commit 41f83e5 into develop Oct 31, 2024
7 checks passed
@shadycuz shadycuz deleted the bug/commadelim-param-intrinsic branch October 31, 2024 00:22
@jamesmcminn96
Copy link

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadycuz shadycuz Awaiting requested review from shadycuz

Assignees
No one assigned
Labels
bug Something isn't working patch A bug, doc or CICD change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use CommaDelimitedList Parameters as inputs to intrinsic functions
3 participants
@dhutchison @jamesmcminn96 @shadycuz