You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I can add a new exit to menu button to a pause screen(#150) but the backend code that exits to the menu will be the same regardless of whether the button is ongui or ugui or where it's located. So I thought I would try to fix what we have now, first.
After changing the += to a -= in SpinnerActivator.cs that seems to have fixed the scoring bug(#179) , though there may still be some delegates that need to be unregistered or cleaned up.
However, apparently exiting to menu breaks the variant changing. I suspect this has to do with there being a new AssetBundleManager created every time the BaseTable scene is loaded. I tried turning off DontDestroyOnLoad for AssetBundleManager(#180), but that didn't seem to fix it. Also, after skimming over some documentation on the AssetBundleManager it seems like killing the AssetBundleManager and then spawning a new one might not be a good way to handle it, because each new AssetBundleManager might be spawning new asset bundles in memory(which it might also be doing now)? As long as their unloaded properly that might not matter, but I don't know enough about it to know if they are.
I also tried forcing AssetBundleManager to be a singleton, like this:
if (go == null)
{
go = this;
}
else if (go != this)
{
Destroy(go);
}
but I'm not entirely sure how to do that with the way the AssetBundleManager is created at runtime.AssetBundleManager.cs#L205
This all begs the question of the importance of the AssetBundleManager going forward, but that probably deserves a separate github issue discussing the pros and cons. I'm hesitant to create one because I feel like I've been creating a lot of github issues, lately, though.
The text was updated successfully, but these errors were encountered:
I can add a new exit to menu button to a pause screen(#150) but the backend code that exits to the menu will be the same regardless of whether the button is ongui or ugui or where it's located. So I thought I would try to fix what we have now, first.
After changing the += to a -= in SpinnerActivator.cs that seems to have fixed the scoring bug(#179) , though there may still be some delegates that need to be unregistered or cleaned up.
However, apparently exiting to menu breaks the variant changing. I suspect this has to do with there being a new AssetBundleManager created every time the BaseTable scene is loaded. I tried turning off DontDestroyOnLoad for AssetBundleManager(#180), but that didn't seem to fix it. Also, after skimming over some documentation on the AssetBundleManager it seems like killing the AssetBundleManager and then spawning a new one might not be a good way to handle it, because each new AssetBundleManager might be spawning new asset bundles in memory(which it might also be doing now)? As long as their unloaded properly that might not matter, but I don't know enough about it to know if they are.
I also tried forcing AssetBundleManager to be a singleton, like this:
but I'm not entirely sure how to do that with the way the AssetBundleManager is created at runtime.AssetBundleManager.cs#L205
This all begs the question of the importance of the AssetBundleManager going forward, but that probably deserves a separate github issue discussing the pros and cons. I'm hesitant to create one because I feel like I've been creating a lot of github issues, lately, though.
The text was updated successfully, but these errors were encountered: