Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backtrace in Regex makes 2.0.0-beta.10 incompatible with Safari (iPhone 11 Pro Max) #40

Closed
kieranbenton opened this issue Dec 30, 2020 · 3 comments

Comments

@kieranbenton
Copy link

Causes:

image

I think I've traced it to ulog, specifically

var items = (value||'').trim().split(/(?<!\\);/).map(function(x){return x.replace('\\;', ';')})

@Download
Copy link
Owner

Download commented Jan 3, 2021

Yes you are right. I reproduced this in Internet Explorer 11 as well. It's got to do with the lookbehind (or ahead?) in split(/(?<!\\);/). I'm working on it right now. Should be fixed in the next beta.

Thank you for reporting this!

@kieranbenton
Copy link
Author

Any luck with this? Do you need a hand?

@Download
Copy link
Owner

What this regex does, is find semicolons that are not preceded by a backslash. The idea was that you can escape semicolons that way. But it is a bit of a fix for a theoretical issue. You don;t need semicolons in any of the config settings as of yet. So I just removed this and changed it to items.split(';'). It's more that I am (again...) refactoring the formatting which is why the next beta is taking some time. Let me see if I can quickly throw out a new beta with just this one issue fixed for you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants