-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Changes at 5/21/2021 6:35:06 PM #6086
Comments
@AndyAyersMS PGO |
The change in @jakobbotsch can you look at the PGO data before/after and see if you can see what might have impacted this? If you open up the details tab under the chart you can find downloads of the two versions that were tested. |
dotnet/runtime@becccb2 is using the 1.0.0-prerelease.21267.7 nuget package of the PGO data while dotnet/runtime@c086077 is using 1.0.0-prerelease.21270.4. Downloading those, merging them (to simulate what the build does) and then comparing them gives the following: https://gist.github.com/jakobbotsch/edb6f940d089aa98b50761351d0b49a4
But:
Some interesting data here. I can see if I can overlay the edge counts on some of their flow graphs tomorrow, though not entirely sure how easy it is to do that with the sparse edge profiles. |
I tried reproducing this locally by downloading the baseline/compare versions in the post above, but the variance seems very high. I tried with the
I used the command in the "repro" section and added |
I think the problem is that Append_Char is in fact just a noisy test that also happened to show a regression across this boundary. I would look at any of the others, besides System.Collections.CreateAddAndClear.HashSet, as all of the others look less noisy. |
Run Information
Regressions in System.Collections.Sort<Int32>
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
System.Collections.Sort<Int32>.LinqOrderByExtension(Size: 512)
System.Collections.Sort<Int32>.LinqQuery(Size: 512)
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Regressions in System.Threading.Tests.Perf_Timer
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
System.Threading.Tests.Perf_Timer.ShortScheduleAndDispose
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Collections.ContainsTrue<Int32>
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
System.Collections.ContainsTrue<Int32>.ImmutableSortedSet(Size: 512)
System.Collections.ContainsTrue<Int32>.SortedSet(Size: 512)
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Collections.CtorFromCollection<Int32>
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
System.Collections.CtorFromCollection<Int32>.SortedList(Size: 512)
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Collections.TryGetValueFalse<Int32, Int32>
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
System.Collections.TryGetValueFalse<Int32, Int32>.ImmutableSortedDictionary(Size: 512)
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Collections.ContainsKeyTrue<Int32, Int32>
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
System.Collections.ContainsKeyTrue<Int32, Int32>.ImmutableSortedDictionary(Size: 512)
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Text.Tests.Perf_StringBuilder
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
System.Text.Tests.Perf_StringBuilder.Append_Char(length: 100000)
System.Text.Tests.Perf_StringBuilder.Append_Char(length: 100)
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Collections.CreateAddAndClear<Int32>
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
System.Collections.CreateAddAndClear<Int32>.SortedSet(Size: 512)
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Collections.ContainsKeyFalse<Int32, Int32>
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
System.Collections.ContainsKeyFalse<Int32, Int32>.ImmutableSortedDictionary(Size: 512)
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in Microsoft.Extensions.Primitives.StringSegmentBenchmark
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
Microsoft.Extensions.Primitives.StringSegmentBenchmark.IndexOfAny
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Diagnostics.Perf_Process
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
System.Diagnostics.Perf_Process.GetCurrentProcess
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Collections.TryGetValueTrue<Int32, Int32>
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
System.Collections.TryGetValueTrue<Int32, Int32>.ImmutableSortedDictionary(Size: 512)
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Collections.CreateAddAndClear<String>
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
System.Collections.CreateAddAndClear<String>.HashSet(Size: 512)
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
The text was updated successfully, but these errors were encountered: