Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for some CTL keys #7

Closed
RedMser opened this issue Jul 1, 2024 · 2 comments
Closed

Add support for some CTL keys #7

RedMser opened this issue Jul 1, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@RedMser
Copy link
Contributor

RedMser commented Jul 1, 2024

I don't think a generic "get/set ctl" API makes sense, since a lot of keys are already available through a nicer API. But some keys could be helpful to expose with a wrapper API, such as:

  • load.skip_plugins (boolean): Set to "1" to avoid loading plugins
  • load.skip_subsongs_init (boolean): Set to "1" to avoid pre-initializing sub-songs. Skipping results in faster module loading but slower seeking.
  • seek.sync_samples (boolean): Set to "0" to not sync sample playback when using openmpt_module_set_position_seconds or openmpt_module_set_position_order_row.

I propose the load.* CTLs to be available as import options and corresponding properties on the stream class.
seek.* would make sense to be part of the playback, and it seems like each playback gets its own mpt_module (thus its own ctls). But maybe it could also be set on the stream, so that each playback gets this value assigned automatically?

@Dudejoe870 Dudejoe870 added the enhancement New feature or request label Jul 2, 2024
@Dudejoe870 Dudejoe870 self-assigned this Jul 2, 2024
@Dudejoe870
Copy link
Owner

Latest commit 2892d65 has added this feature :)

@RedMser
Copy link
Contributor Author

RedMser commented Jul 2, 2024

Thanks for the quick implementation! This is a really useful project, your work is much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants