Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dependency injection in the CorsPolicyService #1312

Closed
josephdecock opened this issue May 31, 2023 · 0 comments · Fixed by #1239
Closed

Improve dependency injection in the CorsPolicyService #1312

josephdecock opened this issue May 31, 2023 · 0 comments · Fixed by #1239
Labels
enhancement New feature or request
Milestone
7.0.0

Comments

@josephdecock
Copy link
Member

The CorsPolicyService originally took a dependency on the IServiceProvider because the CorsMiddleware didn't resolve dependencies dynamically. As of .NET 3.0, that is now fixed, so we can remove this dependency.

See dotnet/aspnetcore#2377 for more detail.
@josephdecock josephdecock linked a pull request May 31, 2023 that will close this issue
Remove IServiceProvider from CorsPolicyService #1239
Merged
@josephdecock josephdecock mentioned this issue May 31, 2023
Closed
@brockallen brockallen added this to the 7.x milestone May 31, 2023
@brockallen brockallen added the enhancement New feature or request label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Remove IServiceProvider from CorsPolicyService DuendeSoftware/IdentityServer
2 participants
@brockallen @josephdecock