Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Otel metrics to PAR implementation #1445

Closed
josephdecock opened this issue Oct 20, 2023 · 4 comments · Fixed by #1467
Closed

Add Otel metrics to PAR implementation #1445

josephdecock opened this issue Oct 20, 2023 · 4 comments · Fixed by #1467
Assignees
Labels
Milestone

Comments

@josephdecock
Copy link
Member

No description provided.

@josephdecock
Copy link
Member Author

@AndersAbel, after your work on OTEL metrics and my work on PAR both get merged, I think we want to add OTEL metrics to the PAR endpoint as well. Also, I didn't introduce new events for PAR, or emit any existing events from the PAR code. What are your thoughts on that? I did it this way since we're trying to emphasize OTEL and de-emphasize our events.

@AndersAbel
Copy link
Member

I agree to not introducing new events. Sounds good adding otel metrics once both are merged.

@brockallen brockallen added this to the 7.0.0 milestone Oct 23, 2023
@josephdecock
Copy link
Member Author

We should instrument /connect/par and also we should update the instrumentation in /connect/authorize to tag requests that used par. We can use ValidatedAuthorizeRequest.IsPushedAuthorizationRequest to know in the authorize endpoint if the request was pushed.

@brockallen
Copy link
Member

This is now merged: #1456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants