-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Japanese Layout - Ctrl + Right Bracket no longer registers any key input. #799
Comments
Hey there @AbstractUmbra ! is there a layout error then? i will review this for RC6 |
So, after checking which layout we implemented, i see a couple discrepancies with the one you added a picture of: Can you tell me which key representation should be shown? cause the brackets is that another Japanese layout? 🤔 |
Hey @alexpargon, thank you for investigating! So Japanese layouts supports 2 layouts. The one you have listed but also the more widely used "106/109 key" layout, as seen on Windows' keyboard selection here:- What's baffling to me is that I suspect the latter has different key codes for keys, but currently I have no way to test as I abandoned my previous keyboard when I got my Defy. I would like to note that this key previously worked on my Defy, but an update several months ago seemed to break it - sorry I can't narrow that down further! |
Hi! Does it output the correct symbol for you when you are typing normally, not holding down ctrl? That position have the same scancode in all keyboard layouts. So unless the firmware can't send CTRL with the scancode 2B the problem should be within your device. What differs is how the operating system translate it. In Japanese (and English) it's "ctrl+oem_5" but in Japanese 106 that specific key outputs "ctrl+oem_6". I will try to install Japanese 106 keyboard layout and try it out myself. The layout within Bazecor appear to be showing the AltGr+Shift state of "symbols" keys instead of ,.\ for when you select them. The actual key that get assigned is correct however. |
The key without CTRL works exactly as intended, yep, that's why I was baffled originally. |
Now using Windows IME for Japanese I can confirm the issue is still present and I am unable to remap a key to |
Interesting. Are you using VS Code yourself? Did it come up as another combination?
|
I am using VSCode myself, yes, and no, when trying to bind to CTRL + ] it will simply show I have the wireless Defy, but have tried it both wired and wireless with the same issue. |
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Use the Japanese layout within Bazecor.
Map a key to 『む』which is the right bracket key.
Attempt to use ctrl + this key, such as within a text editor / IDE.
Expected behavior
The key combination to register and input accordingly.
Screenshots
Unsure of how to provide visual information, but if any can be provided by me then please let me know.
Desktop (please complete the following information):
Additional context
Using things like Toptal's keycode viewer I cannot force this combination to input. I tried also remapping things within my IDE/editor to use Ctrl + む but the combination never inputs.
However Ctrl + 。works as intended, as this is Ctrl + [.
I believe also the Bazecor UI has these keys backwards:-
Using these reference image of a Japanese keyboard
We can see that む is
]
,}
and」
, but in the Bazecor UI, editing my む key shows it as”
and@
:-I am using a Dygma Defy.
The text was updated successfully, but these errors were encountered: