Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions の PHP7.4 での UnitTest の testReadCsvFileWithTrailingBlankLines が落ちる #5072

Open
okazy opened this issue Jun 22, 2021 · 1 comment
Labels
Milestone

Comments

@okazy
Copy link
Contributor

okazy commented Jun 22, 2021

概要(Overview)

PHP7.4 で UnitTest の testReadCsvFileWithTrailingBlankLines が落ちる。
PHP7.3 以前は落ちない。
4.0.6 / 4.1-core ブランチで発生。
ライブラリのバージョンの関連は詳しく調査できていない。
2021/06/20 前後からテストが落ちることを確認しているが、原因は不明。

1) Eccube\Tests\Service\CsvImportServiceTest::testReadCsvFileWithTrailingBlankLines
Undefined index: id
/home/runner/work/ec-cube/ec-cube/tests/Eccube/Tests/Service/CsvImportServiceTest.php:97

期待する内容(Expect) or 要望 (Requirement)

テストが通るように対応

再現手順(Procedure)

環境 (environment)

  • EC-CUBE: 4.0.6 ~ 4.1

関連情報 (Ref)

@okazy okazy added the bug label Jun 22, 2021
@okazy okazy added this to the 4.0.x milestone Jun 22, 2021
@nanasess
Copy link
Contributor

SplFileObject::DROP_NEW_LINE の挙動が変わった可能性
https://qiita.com/suin/items/5f2322d2762d7d1677bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants