Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] MultiFabRegister: throw in get #5356

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

[WIP] MultiFabRegister: throw in get #5356

wants to merge 1 commit into from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Oct 2, 2024 •
edited
Loading

Close #5319
Follow-up to #5230

  • Throw a runtime exception instead of returning a nullptr if a field is requested via the getter.
  • update logic to ensure this passes all tests

@ax3l ax3l added cleaning Clean code, improve readability component: ABLASTR components shared with other PIC codes labels Oct 2, 2024
@ax3l ax3l requested a review from EZoni October 2, 2024 15:54
@ax3l
MultiFabRegister: throw in get
2c2f48c 
Throw a runtime exception instead of returning a `nullptr` if a
field is requested via the getter.
@ax3l ax3l requested a review from lucafedeli88 October 2, 2024 16:19
@ax3l ax3l changed the title MultiFabRegister: throw in get [WIP] MultiFabRegister: throw in get Oct 2, 2024
@ax3l ax3l added the help wanted Extra attention is needed label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EZoni EZoni Awaiting requested review from EZoni

@lucafedeli88 lucafedeli88 Awaiting requested review from lucafedeli88

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cleaning Clean code, improve readability component: ABLASTR components shared with other PIC codes help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw error in MultiFabRegister.get when a field does not exist
1 participant
@ax3l