Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value of smallCellCount #37

Open
MaximMoinat opened this issue Jan 13, 2022 · 0 comments · Fixed by #38
Open

Change default value of smallCellCount #37

MaximMoinat opened this issue Jan 13, 2022 · 0 comments · Fixed by #38
Assignees
Labels
enhancement New feature or request

Comments

@MaximMoinat
Copy link

MaximMoinat commented Jan 13, 2022

Is your feature request related to a problem? Please describe.
Related to the question in the discussion reported here: #36
The small cell count is applied after the rounding to the nearest 100. This means, that at a default smallCellCount of 5, none of the counts are filtered out and displayed as 100.
Users probably don't expect that the CatalogueExport will actually show the codes that occur less frequently than the smallCellCount.

Describe the solution you'd like
Easy temporary solution: Change the smallCellCount default value to 100.

Proper solution: Apply the small cell count to the original count value, before rounding up to nearest 100. This can be done by keeping the original count in each analysis and at the merge step apply the small cell count on that original count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant