Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[docs] Error in an example #9036

Open
sergioyuhjtman opened this issue May 3, 2020 · 4 comments
Open

[docs] Error in an example #9036

sergioyuhjtman opened this issue May 3, 2020 · 4 comments
Assignees
Labels
documentation Requires attention from documentation team. e.g. documentation is expected to be generated. staging doc-related issue has been resolved in merged PR. moved to staging phase for production testing.

Comments

@sergioyuhjtman
Copy link

The first example:
cleos set account permission test active '{"threshold" : 1, "keys" : [{"permission":{"key":"EOS8X7Mp7apQWtL6T2sfSZzBcQNUqZB7tARFEm9gA9Tn9nbMdsvBB","permission":"active"},"weight":1}], "accounts" : [{"permission":{"account":"acc2","permission":"active"},"weight":50}]}' owner

is wrong, because it associates "active" to the key EOS8X7... which is meaningless. And the command does not work. I think the correct line is:

'{"threshold" : 1, "keys" : [{"key":"EOS8X7Mp7apQWtL6T2sfSZzBcQNUqZB7tARFEm9gA9Tn9nbMdsvBB","weight":1}], "accounts" : [{"permission":{"account":"acc2","permission":"active"},"weight":50}] }' owner

File: [docs/02_cleos/03_command-reference/set/set-account.md](https://github.com/EOSIO/eos/blob/develop/docs/02_cleos/03_command-reference/set/set-account.md)
@sergioyuhjtman
Copy link
Author

The same applies to the third example and possibly the last one too.

@jgiszczak jgiszczak added the documentation Requires attention from documentation team. e.g. documentation is expected to be generated. label May 8, 2020
@lparisc
Copy link
Contributor

lparisc commented May 18, 2020

@sergioyuhjtman the association between a key and a named permission in the authority table of the receiving account is meaningful as it indicates the minimum permission the key's associated actor should have for the action to be authorized. What seems to be inaccurate is the example's description in the docs. It should read that it associates the "active" permission of the receiving account with an authority that defines a weight threshold of 1 and a minimum permission of "active" for key "EOS8X7..." and account "acc2", each with weights 1 and 50, respectively. In your proposed example, "keys" should be a list of key_weight permissions and should include the named permission.

@sergioyuhjtman
Copy link
Author

@lparisc Have in mind that the command, as is today in the docs https://developers.eos.io/manuals/eos/latest/cleos/command-reference/set/set-account
does not work, while the one I proposed does.

@lparisc
Copy link
Contributor

lparisc commented May 19, 2020

Thanks @sergioyuhjtman we'll repro and get back to you @dixia

@lparisc lparisc added the staging doc-related issue has been resolved in merged PR. moved to staging phase for production testing. label Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Requires attention from documentation team. e.g. documentation is expected to be generated. staging doc-related issue has been resolved in merged PR. moved to staging phase for production testing.
Projects
None yet
Development

No branches or pull requests

4 participants