Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Circular dependency issues #969

Closed
o-alexandrov opened this issue Jun 28, 2021 · 2 comments
Closed

Circular dependency issues #969

o-alexandrov opened this issue Jun 28, 2021 · 2 comments

Comments

@o-alexandrov
Copy link

o-alexandrov commented Jun 28, 2021

Version of EOSJS
22.0.0

Describe the bug

The issue was probably partially resolved in #946
These are the remaining circular dependency issues when bundling eosjs v22.0.0 with latest rollup v2.52.3:

Circular dependency: ../node_modules/eosjs/dist/eosjs-key-conversions.js -> ../node_modules/eosjs/dist/PublicKey.js -> ../node_modules/eosjs/dist/eosjs-key-conversions.js
Circular dependency: ../node_modules/eosjs/dist/eosjs-key-conversions.js -> ../node_modules/eosjs/dist/PublicKey.js -> ../node_modules/eosjs/dist/eosjs-key-conversions.js?commonjs-proxy -> ../node_modules/eosjs/dist/eosjs-key-conversions.js
Circular dependency: ../node_modules/eosjs/dist/eosjs-key-conversions.js -> ../node_modules/eosjs/dist/PrivateKey.js -> ../node_modules/eosjs/dist/eosjs-key-conversions.js
Circular dependency: ../node_modules/eosjs/dist/eosjs-key-conversions.js -> ../node_modules/eosjs/dist/Signature.js -> ../node_modules/eosjs/dist/eosjs-key-conversions.js
@bradlhart
Copy link
Contributor

Ideally this should be resolved with #937. Do you have a list of steps that I can check to confirm that this is the case?

@o-alexandrov
Copy link
Author

@bradlhart I apologize for missing your message here.

I checked latest develop with changes from #937 merged into develop on Sep 7th, 2021.

  • eosjs version at the time of new testing was 22.2.0

Thank you, the circular dependency issue is resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants