Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset problem: CMORCheckError for MOHC-HadREM3-GA7-05 CORDEX data. (Wrong latitude and longitude names) #1044

Open
thomascrocker opened this issue Mar 12, 2021 · 4 comments
Assignees

Comments

@thomascrocker
Copy link
Contributor

thomascrocker commented Mar 12, 2021

Data from the Met Office run CORDEX EUR-11 domain experiments fail CMOR checking:

ERROR Failed to run fix_metadata([<iris 'Cube' of air_temperature / (K) (time: 120; grid_latitude: 412; grid_longitude: 424)>, <iris 'Cube' of air_temperature / (K) (time: 120; grid_latitude: 412; grid_longitude: 424)>, <iris 'Cube' of air_temperature / (K) (time: 120; grid_latitude: 412; grid_longitude: 424)>], {'project': 'CORDEX', 'dataset': 'MOHC-HadREM3-GA7-05', 'short_name': 'tas', 'mip': 'mon', 'frequency': 'mon', 'check_level': <CheckLevels.DEFAULT: 3>})

esmvalcore.cmor.check.CMORCheckError: There were errors in variable tas:
Coordinate longitude has var name longitude instead of lon
Coordinate latitude has var name latitude instead of lat

  • Data file has been changed by you in any way (if you answer yes the issue will be void and closed, we are not
    supporting custom-made datasets that present problems, it is your resposability to fix those problems): No

  • Project (CMIP5/CMIP6/OBS/obs4mips/etc): CORDEX

  • Full dataset description (fill out as many as you know, please):

    • dataset: MOHC-HadREM3-GA7-05
    • experiment: historical and rcp85
    • mip: mon
    • grid: N/A
    • type:
    • version: v2
    • tier: N/A
    • variable used: tas
    • data version:
  • Problems encountered (please describe what the actual problems are: e.g. wrong standard name, issue with dimensions): Wrong dimension names.

  • Pointer to existing copy of data on ESGF node (it would be very useful if you could provide a physical
    fullpath to the file(s) that are causing the problem, e.g. on CEDA Jasmin or DKRZ): /badc/cordex/data/CORDEX/output/EUR-11/MOHC/CNRM-CERFACS-CNRM-CM5/historical/r1i1p1/MOHC-HadREM3-GA7-05/v2/mon/tas/latest/tas_EUR-11_CNRM-CERFACS-CNRM-CM5_historical_r1i1p1_MOHC-HadREM3-GA7-05_v2_mon_199101-200012.nc
    main_log_debug.txt
    ncdump.txt
    recipe_cordex_test.yml.txt
    (txt extension added since github wouldn't let me upload a .yml file ¯_(ツ)_/¯

  • Other notes and mentions: To my knowledge this appears to affect all data under MOHC in the EUR-11 domain. I suspect this may affect all MO RCM data and is related to the CMORization settings that have been used in internal CMORization suites, since I see the same errors working internally with data from the EUCP CPM experiments (they have not been uploaded to ESGF yet, but are planned to be), and also saw the same behaviour with data from own Caribbean RCM model experiments that were CMORized at the Met Office. Recipes using these datasets work without issue by setting check_level=relaxed when running

Assign the right people
If you are already a member of the ESMValTool GitHub project, please assign Valeriu Predoi (valeriupredoi) and
Klaus Zimmermann (zklaus) to the issue. They will then check the issue raised and propagate it further to the
data model developers.
@valeriupredoi @zklaus

Please attach

  • The recipe that you are trying to run, you can find a copy in the run directory in the output directory
  • The main_log_debug.txt file, this can also be found in the run directory in the output directory
  • Attach a text file with the output of ncdump -h /path/to/file.nc

Cheers 🍺

@thomascrocker
Copy link
Contributor Author

I think I have developed a fix for this (by creating a module that fixes the var names under /cmor/_fixes in ESMValCore), but I can't push my branch to the repo to open a pull request. Can someone grant me permissions to do so? Is there anything special I need to do?

@zklaus
Copy link

zklaus commented Mar 26, 2021

Great that you wrote a fix already! I have sent you an email on how to join the team.

@thomascrocker
Copy link
Contributor Author

OK. PR open. I had a guess at assigning @jvegasbsc for review since he appeared to be the author of similar fixes that were my main inspiration.

@zklaus
Copy link

zklaus commented Mar 31, 2021

I think that this might not be an error in the original data, but rather a consequence of one of our own earlier fixes :/ We'll have to have another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants