Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable information from recipes overwritten by cmor table info when deriving custom variables #1388

Closed
remi-kazeroni opened this issue Nov 5, 2021 · 2 comments · Fixed by #2255
Labels
bug Something isn't working cmor Related to the CMOR standard

Comments

@remi-kazeroni
Copy link
Contributor

Describe the bug
In #2396, it was found out that variable information (e.g. frequency) specified in a recipe to derive a custom variable can be overwritten by reading cmor tables and this can lead to inconsistencies like in the case of ERA5 hourly data. It is not clear if this issue only affects ERA5 variable derivation for hourly data or other datasets/variable derivations as well.

Below is an example where the 1hr frequency used for ERA5 hourly variable is overwritten to 1hrPt when deriving custom variables. Consequently, input variables needed for the derivation are not found and the recipe fails.

Please attach

@remi-kazeroni remi-kazeroni added bug Something isn't working cmor Related to the CMOR standard labels Nov 5, 2021
@remi-kazeroni remi-kazeroni added this to the v2.5.0 milestone Nov 5, 2021
@schlunma
Copy link
Contributor

schlunma commented Feb 4, 2022

Moving this to v2.6 since there is not open PR yet.

@schlunma schlunma modified the milestones: v2.5.0, v2.6.0 Feb 4, 2022
@sloosvel sloosvel removed this from the v2.6.0 milestone Jun 7, 2022
@bouweandela
Copy link
Member

bouweandela commented Nov 13, 2023

Background information: the recipes fails for variables:

  • rlus: derived from rlds (surface_thermal_radiation_downwards) and rlns (surface_net_thermal_radiation)
  • rsus: derived from rsds (surface_solar_radiation_downwards) and rsns (surface_net_solar_radiation)

All of these from Table 3: surface and single level parameters: accumulations shown here so have frequency 1hr.

Since there is no entry for these variables in the CMIP6 E1hr table, the most frequent frequency in that table is used which is 1hrPt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cmor Related to the CMOR standard
Projects
None yet
4 participants