Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up builds #911

Closed
jaskij opened this issue Jul 2, 2024 · 2 comments
Closed

Speed up builds #911

jaskij opened this issue Jul 2, 2024 · 2 comments

Comments

@jaskij
Copy link
Contributor

jaskij commented Jul 2, 2024

Something I noticed is that current GHA workflows simply call make - which defaults to running the jobs sequentially. Meanwhile, GitHub's public runners have more than one CPU core.

Your builds could probably be significantly sped up by changing the make call to something like make -j4, or more universally make -j $(nproc). It could also be possible to switch over to ninja (which defaults to one job per CPU thread), but I don't think it's installed by default in GHA images.

@jaskij
Copy link
Contributor Author

jaskij commented Jul 2, 2024

I'll take care of this one once #907 is merged.

It also seems to me that there's a lot of opportunity for deduplication in workflow code, utilizing matrices and environment variables.

@jwellbelove
Copy link
Contributor

It also seems to me that there's a lot of opportunity for deduplication in workflow code, utilizing matrices and environment variables.

You're probably correct.
I look forward to seeing what you propose.

@jaskij jaskij mentioned this issue Jul 2, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants