Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check arguments in edm release handler #44

Open
1 task
andistorm opened this issue Jul 4, 2024 · 0 comments
Open
1 task

Check arguments in edm release handler #44

andistorm opened this issue Jul 4, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@andistorm
Copy link
Contributor

Description

When calling edm release --everest-core-dir with-wrong-arg in this line the function get_git_repo_info returns a dictionary without the fields rev, branch and tag which are required for the following lines.

Code Reference

See: https://github.com/EVerest/everest-dev-environment/blob/main/dependency_manager/src/edm_tool/edm.py#L1299-L1306

Expected behaviour

When using the edm release command with invalid arguments it would be nice to get an explaining warning/error

Additional

  • Check other locations where this function is used to add there checks, too
@andistorm andistorm added the good first issue Good for newcomers label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant