ActiveMonitoringBase not correctly implemented

[robert-s-ubi]

OCPP Version

OCPP2.0.1

Describe the bug

The OCPP 2.0.1 "ActiveMonitoringBase" is intended to be a BASE, not an enable level. Specifically, custom monitors can be set on top of the HardwiredOnly and FactoryDefault monitoring bases.

However, monitoring_updater.cpp seems to handle it as a "class enable" setting, which is not correct. Correctly handling the monitoring base is a bit more complex:

• persist the monitoring base, the custom monitors AND the cleared pre-configured monitors
• on reboot, reconstruct the active monitors from the monitoring base, the cleared pre-configured monitors and the added custom monitors
• on SetMonitoringBase with HardwiredOnly or FactoryDefault, remove all custom monitors (and all persisted "clearings" of pre-configured monitors)
• on SetMonitoringBase with ALL, restore all FactoryDefault monitors which have not been replaced by a custom monitor

To Reproduce

No response

Anything else?

No response

[AssemblyJohn]

Thank you for the report, we're on it.