Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public inputs calculation from nightfall-client transfer service #529

Closed
Westlad opened this issue Feb 24, 2022 · 0 comments · Fixed by #563
Closed

Remove public inputs calculation from nightfall-client transfer service #529

Westlad opened this issue Feb 24, 2022 · 0 comments · Fixed by #563
Assignees

Comments

@Westlad
Copy link
Contributor

Westlad commented Feb 24, 2022

The calculation of public inputs in the transfer.mjs service is incorrect; it includes the ercAddress variable, which must be hidden for a transfer transaction. The ZKP layer is correct however and does not expose ercAddress.

This works because the public inputs are only really used to derive the L2 transaction hash and, although this value is incorrect for a transfer, it's not used offchain anywhere.

We should remove this incorrect code, even though it currently appears to have no deleterious effect, it may be assume correct in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants