From 8170a620d2d94cc4d08e83d06512c8fd8e826c0e Mon Sep 17 00:00:00 2001
From: Westlad <Duncan.Westland@uk.ey.com>
Date: Mon, 14 Feb 2022 14:53:21 +0000
Subject: [PATCH] feat: remove secrets from deploy script

---
 .github/workflows/development-deploy.yml | 4 ++++
 deployment-scripts/dev.env               | 3 +--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/development-deploy.yml b/.github/workflows/development-deploy.yml
index 9fc4347b8..c1405fbca 100644
--- a/.github/workflows/development-deploy.yml
+++ b/.github/workflows/development-deploy.yml
@@ -96,6 +96,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v2
+      - name: Add secret environment variables
+        run: |
+          echo "ETH_PRIVATE_KEY=${{ secrets.ETH_PRIVATE_KEY }}" >> deployment-scripts/dev.env
+          echo "PROPOSER_ETHEREUM_SIGNING_KEY=${{ secrets.PROPOSER_ETHEREUM_SIGNING_KEY }}" >> deployment-scripts/dev.env
       - name: Configure SSH
         run: |
           mkdir -p ~/.ssh/
diff --git a/deployment-scripts/dev.env b/deployment-scripts/dev.env
index 41a9cb887..e5f045d4e 100644
--- a/deployment-scripts/dev.env
+++ b/deployment-scripts/dev.env
@@ -2,7 +2,6 @@ BLOCKCHAIN_WS_HOST=ropsten1-ws.testnet.nightfall3.com
 BLOCKCHAIN_PORT=80
 AUTOSTART_RETRIES=10000
 ETH_NETWORK=ropsten
-ETH_PRIVATE_KEY=abf4ed9f30bd1e4a290310d726c7bbdf39cd75a25eebd9a3a4874e10b4a0c4ce
 ETH_ADDRESS='0xdb080dC48961bC1D67a0A4151572eCb824cC76E8'
 TRANSACTIONS_PER_BLOCK=2
-PROPOSER_ETHEREUM_SIGNING_KEY=645ac79fa9fd87dd1cf30bdca51d326bd501cd328d6dbc9f5f517c7da0dafa6f
+# Other variables may be added here from GitHub secrets during deployment