Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring test files #265

Closed
ChaitanyaKonda opened this issue Nov 3, 2021 · 1 comment · Fixed by #329
Closed

Refactoring test files #265

ChaitanyaKonda opened this issue Nov 3, 2021 · 1 comment · Fixed by #329
Assignees
@daveroga

Comments

@ChaitanyaKonda
Copy link
Contributor

ChaitanyaKonda commented Nov 3, 2021 •
edited
Loading

Changing or adding anything to test files breaks it.

There are a few of good reasons why now is a good time:

  1. Significant code changes to master have altered the speed/flow of our code (probably contributing to the increase in heisenbugs), some of the hacks might also not be required anymore (or in some cases maybe making it worse).
  2. We have nice utilities in utils or in the sdk that could potentially minimise the boilerplate that plagues the tests except for neg-http.mjs test
  3. We’ve developed quite a bit of tooling around event-introspection, however, they’re duplicated and spread out messily in each test - this could be an opportunity to clean up and refine these.
  4. Resolving issue Instant withdrawal failing when error status code 500  #232
  5. Testing these refactored tests against testnet deployment
@daveroga daveroga self-assigned this Nov 11, 2021
daveroga added a commit that referenced this issue Nov 18, 2021
@daveroga
feat: refactoring test v0.1. fixes #265
0a93f4c
daveroga added a commit that referenced this issue Nov 22, 2021
@daveroga
feat: refactoring test v0.1. fixes #265
afb6e92
@daveroga daveroga linked a pull request Nov 24, 2021 that will close this issue
Daveroga/refactoring test files fixes #265, #307, #331 #329
Merged
daveroga added a commit that referenced this issue Nov 25, 2021
@daveroga
feat: refactoring test v0.1. fixes #265
5c4b804 
rebase to fix conflicts ERC json/abis
daveroga added a commit that referenced this issue Dec 1, 2021
@daveroga
Merge pull request #329 from EYBlockchain/daveroga/refactoring-test-f…
f8b263a 
…iles

Daveroga/refactoring test files fixes #265, #307, #331
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daveroga daveroga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Daveroga/refactoring test files fixes #265, #307, #331 EYBlockchain/nightfall_3
2 participants
@ChaitanyaKonda @daveroga