[BUG] <adds multiple milestones>

[malay44]

Has this bug been raised before?

• I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

while adding milestone sectio

Version of BioDrop (for example "v1.2.3")

2.83.14

Description

when clicked multiple times on save button in milestone section, it sends many requests which results in adding of the same milestone multiple times

Screenshots

Do you want to work on this issue?

Yes

If you want to work on this issue...

By disabling the button when the request is sent.

[github-actions]

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

[sital002]

@malay44 Good spot assigning the issue to you.

[github-actions]

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

[eddiejaoude]

I was unable to replicate this bug. Milestones redirects after the save, similar to the links page. Are you trying to purposely break it by clicking multiple times before the request comes back successful and the page redirects?

If the above steps to reproduce are correct, it sounds like an edge case and would effect all manage pages and those would need to be updated accordingly too so they are consistent.

[sital002]

I was unable to replicate this bug. Milestones redirects after the save, similar to the links page. Are you trying to purposely break it by clicking multiple times before the response comes back successful and the page redirects?

If the above steps to reproduce are correct, it sounds like an edge case and would effect all manage pages and those would need to be updated accordingly too so they are consistent.

If you spam the save button it would create the milestone multiple times what they are suggesting is to disable the button until the response comes so that there is only one request.

[malay44]

I was unable to replicate this bug. Milestones redirects after the save, similar to the links page. Are you trying to purposely break it by clicking multiple times before the request comes back successful and the page redirects?

If the above steps to reproduce are correct, it sounds like an edge case and would effect all manage pages and those would need to be updated accordingly too so they are consistent.

I would also update other manage pages 😊.

[eddiejaoude]

I would also update other manage pages 😊.

Thank you 👍 I suggest you do 1 page first and create a draft PR and it can be reviewed, then you can apply it to all other pages afterwards if approved